https://bugzilla.wikimedia.org/show_bug.cgi?id=26804

           Summary: Minor ResourceLoader code clean up
           Product: MediaWiki
           Version: wikimedia-deployment
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: Resource Loader
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]


* ( multiple methods calls to generate local variables ) in
ResourceLoader::preloadModuleInfo you set $skin to $context->getSkin(); then
for db select call $context->getSkin(); again.

* In the register call you should check and throw an error for an empty $name
argument since it fails in mysterious ways if you happen to mess up your array
merges before your register calls.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to