https://bugzilla.wikimedia.org/show_bug.cgi?id=26860

--- Comment #1 from Brion Vibber <[email protected]> 2011-01-22 17:27:37 UTC ---
Created attachment 8018
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=8018
Partial patch; see comment for issues with ordering

It's relatively easy to split the style blocks into separate head items for the
language-specific styles and the site-specific overrides, which would let
OutputPage automatically sort out the dupes and only actually output one
instance of the including of MediaWiki:Geshi.css

*However*... there's a catch. :) The purpose of the customizable styles is to
allow people to override the GeSHi default styles; to accomplish this it must
be included *after* all the default style blocks.

If we make it its own separate head item, it'll get included after the first
language style block, but *before* any subsequent ones. Custom styles with the
same selector priority as those in the default styles could get overridden back
to the defaults, and not be very easy to debug -- especially since most of the
time there'll probably only be a single language per page and the bug won't bee
seen.

(!important entries can force an override, but folks likely won't know they
need it.)

If it can be pushed down below later invocations of the plugin, then it'll do
the job.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to