https://bugzilla.wikimedia.org/show_bug.cgi?id=27052

           Summary: CSS minification regression in ResourceLoader:
                    relative links to images not resolved correctly
           Product: MediaWiki
           Version: 1.18-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: Normal
         Component: Resource Loader
        AssignedTo: tpars...@wikimedia.org
        ReportedBy: br...@pobox.com
                CC: roan.katt...@gmail.com


I noticed a regression in the CSS minification that has broken the load/save
spinner from showing in SVGEdit extension...

>From styles in ext.svgedit.edit.editButton.css; original source:

#mw-svgedit-spinner {
    position: absolute;
    top: 2em;
    left: 0;
    right: 0;
    bottom: 0;
    background: rgba(0,0,0,0.5)
         url("../images/ajax-loader.gif")
         50%
         no-repeat;
    z-index: 999999
}

as minified with current trunk code:

#mw-svgedit-spinner {
    background:
url("/trunk/extensions/SVGEdit/modules//../images/ajax-loader.gif?2011-01-22T00:58:20Z")
no-repeat scroll 50% 50% rgba(0, 0, 0, 0.5);


This ends up resolving to (on my localhost):
http://stormcloud.local/trunk/extensions/SVGEdit/modules/images/ajax-loader.gif?2011-01-22T00:58:20Z

where it should instead load:
http://stormcloud.local/trunk/extensions/SVGEdit/images/ajax-loader.gif?2011-01-22T00:58:20Z

Looks like the problem is that double slash: "modules//../images" -- if it
instead said "modules/../images" it should at least resolve correctly
client-side.

Relative module paths used for SVGEdit's module:

$myResourceTemplate = array(
    'localBasePath' => dirname( __FILE__ ) . '/modules',
    'remoteExtPath' => 'SVGEdit/modules',
    'group' => 'ext.svgedit',
);

Possible workaround: relative paths that don't need to bump into "../"
territory appear to work with the double slashes, so if image and font
resources are always at the same directory level or in a subdirectory of where
the CSS lives, it should still work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to