https://bugzilla.wikimedia.org/show_bug.cgi?id=27173

--- Comment #14 from Derk-Jan Hartman <hart...@videolan.org> 2011-02-06 
19:30:26 UTC ---
This is caused because in FlaggedArticleView.php, setRobotPolicy has the
following check:

<pre>
if ( !$this->pageOverride() && $this->article->isStableShownByDefault() ) {
// set noindex
}
</pre>

in this check, $this->pageOverride() returns false for stable versions for
logged in users, yet true for stable versions for non-logged in users.

pageOverride() returns false for logged in users, due to the following check:

<pre>
                $config = $this->article->getVisibilitySettings();
                # Does the stable version override the current one?
                if ( $config['override'] ) {
                        if ( $this->showDraftByDefault() ) {
                                return ( $wgRequest->getIntOrNull( 'stable' )
=== 1 );
                        }
                        # Viewer sees stable by default
                        return !( $wgRequest->getIntOrNull( 'stable' ) === 0 );
</pre>

ergo, pageOverride() does not account for usergroup settings in viewing stable
pages, it only takes into account usersettings, page settings and url
overrides.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to