Summary: RL: Avoid unnecessary and uncached requests for user
                    and site modules
           Product: MediaWiki
           Version: 1.18-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: Resource Loader

Created attachment 8120
Simple fix for OutputPage::makeResourceLoaderLink

If a ResourceLoaderWikiModule (user or site) is empty, i.e. the relevant pages
doesn't exist, there should be no link to it from the html to avoid unnecessary

Currently, it doesn't only output the link, but also adds a version parameter
with the current timestamp, which bypasses all caches. This is due to a bug in
OutputPage::makeResourceLoaderLink, where the modifiedTimestamp of the module
is rounded to 0 if it returns 1.

This bug occurs in the following circumstances:

* For the site module, if MediaWiki:Common.js and MediaWiki:<Skin>.js is empty.
* For the user css module, if not logged in.
* For the user js module, if logged in and the user js pages are empty.

Simple fix attached.

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug.

Wikibugs-l mailing list

Reply via email to