https://bugzilla.wikimedia.org/show_bug.cgi?id=27302
Summary: RL: Avoid unnecessary and uncached requests for user
and site modules
Product: MediaWiki
Version: 1.18-svn
Platform: All
URL: http://translatewiki.org
OS/Version: All
Status: NEW
Severity: normal
Priority: Normal
Component: Resource Loader
AssignedTo: tpars...@wikimedia.org
ReportedBy: paul.copper...@gmail.com
CC: roan.katt...@gmail.com
Created attachment 8120
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8120
Simple fix for OutputPage::makeResourceLoaderLink
If a ResourceLoaderWikiModule (user or site) is empty, i.e. the relevant pages
doesn't exist, there should be no link to it from the html to avoid unnecessary
requests.
Currently, it doesn't only output the link, but also adds a version parameter
with the current timestamp, which bypasses all caches. This is due to a bug in
OutputPage::makeResourceLoaderLink, where the modifiedTimestamp of the module
is rounded to 0 if it returns 1.
This bug occurs in the following circumstances:
* For the site module, if MediaWiki:Common.js and MediaWiki:<Skin>.js is empty.
* For the user css module, if not logged in.
* For the user js module, if logged in and the user js pages are empty.
Simple fix attached.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
