https://bugzilla.wikimedia.org/show_bug.cgi?id=9237

Reedy <s...@reedyboy.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s...@reedyboy.net

--- Comment #10 from Reedy <s...@reedyboy.net> 2011-02-11 01:20:33 UTC ---
This seems to still be a valid bug, using the basic query used in
SpecialBrokenRedirects, adding in the rd_interwiki col, we get the below

mysql> SELECT p1.page_namespace AS namespace,p1.page_title AS
title,rd_namespace,rd_title,rd_interwiki  FROM `mw_redirect` LEFT JOIN
`mw_page` `p1` ON ((rd_from=p1.page_id)) LEFT JOIN `mw_page` `p2` ON
((rd_namespace=p2.page_namespace) AND (rd_title=p2.page_title))  WHERE
(rd_namespace >= 0) AND (p2.page_namespace IS NULL)  ORDER BY rd_namespace,
rd_title, rd_from LIMIT 50\g
+-----------+-------+--------------+----------+--------------+
| namespace | title | rd_namespace | rd_title | rd_interwiki |
+-----------+-------+--------------+----------+--------------+
|         0 | Test2 |            0 | Test     | wikipedia    |
+-----------+-------+--------------+----------+--------------+

[[Test2]] -> #REDIRECT [[wikipedia:Test]]

The following redirects link to non-existent pages:
Showing below up to 1 result starting with #1.
View (previous 50 | next 50) (20 | 50 | 100 | 250 | 500)
Test2 (edit | delete) → Test



So would look like this still needs fixing. But if the fix is so simple, we
should do it and get this bug closed :)


Would

SELECT p1.page_namespace AS namespace,p1.page_title AS
title,rd_namespace,rd_title,rd_interwiki  FROM `mw_redirect` LEFT JOIN
`mw_page` `p1` ON ((rd_from=p1.page_id)) LEFT JOIN `mw_page` `p2` ON
((rd_namespace=p2.page_namespace) AND (rd_title=p2.page_title))  WHERE
(rd_namespace >= 0) AND (p2.page_namespace IS NULL)  ORDER BY rd_namespace,
rd_title, rd_from LIMIT 50\g

to

SELECT p1.page_namespace AS namespace,p1.page_title AS
title,rd_namespace,rd_title,rd_interwiki  FROM `mw_redirect` LEFT JOIN
`mw_page` `p1` ON ((rd_from=p1.page_id)) LEFT JOIN `mw_page` `p2` ON
((rd_namespace=p2.page_namespace) AND (rd_title=p2.page_title))  WHERE
(rd_namespace >= 0) AND (p2.page_namespace IS NULL) AND (rd_interwiki = '') 
ORDER BY rd_namespace, rd_title, rd_from LIMIT 50\g

(that is, adding "AND (rd_interwiki = '') "), be enough to fix this? That way
the brroken redirect query isn't including things that redirect to IW

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to