https://bugzilla.wikimedia.org/show_bug.cgi?id=25934

--- Comment #7 from Brion Vibber <br...@pobox.com> 2011-02-12 06:26:31 UTC ---
Stumbled on this in bugzilla... I like the basic idea of the patch, but there's
a couple of issues which'll need to be worked out.

First, not all URLs with encoded characters are encoded in UTF-8... while we
like to hope that most of them are in this day and age, there's no guarantee.
Russian, Japanese, Chinese, etc sites may still use other national encodings,
especially on older links...

Reasonable behavior would at least need to check for UTF-8 validity to avoid
outputting garbage characters.


Second, there are lots of meaningful characters in URLs where the difference
between being encoded and not actually changes the URL; for instance Firefox
will show

http://en.wikipedia.org/wiki/What%27s_Eating_Gilbert_Grape%3F

as:

http://en.wikipedia.org/wiki/What's_Eating_Gilbert_Grape%3F

and not as:

http://en.wikipedia.org/wiki/What%27s_Eating_Gilbert_Grape?
which would actually point to "[[What's Eating Gilbert Grape]]" with an empty
query string on the end if you copy-pasted the text.


Third, if the above are resolved, I'd probably be pretty happy with *not*
adding the parameter on makeExternalLink() -- it's probably sane behavior for
the automatic formatting of the bare link display in pretty much all cases.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to