https://bugzilla.wikimedia.org/show_bug.cgi?id=27528

P.Copp <paul.copper...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #5 from P.Copp <paul.copper...@gmail.com> 2011-02-18 17:49:26 UTC 
---
Reopening per my comment above. As pointed out, it's not possible to minify js
with simple regexes without breaking user code in some cases.

FTR here are two sample test cases that currently break:

> echo JavascriptDistiller::stripWhiteSpace("alert( (10+10) / '/'.charCodeAt( 0 
> ) ) + '//' );\n");
alert((10+10)/ '/'.charCodeAt( 0 ) ) + '

> echo JavascriptDistiller::stripWhiteSpace("if(1)/a /g.exec('Pa ss');");
if(1)/a/g.exec('Pa ss');

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to