Summary: Make $wgVersion a constant
           Product: MediaWiki
           Version: 1.18-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: General/Unknown
            Blocks: 700,9968

Currently, $wgVersion is global variable from DefaultSettings.php, which means
that it's easily possible for people to modify the variable in
LocalSettings.php. I don't know if anyone ever did it, but if someone did it,
this could break quite a lot of things. Version checks with version_compare()
might be inaccurate, leading to certain functions/classes not to load or the
information on Special:Version or {{VERSION}} give wrong information about the
used software. Also, I could imagine people believing they could "update"
MediaWiki by modifying $wgVersion.

Since there doesn't appear to be a need to modify $wgVersion, neither by the
MediaWiki core, extensions or the site users, it could probably just as easily
become a constant, maybe MW_VERSION, and then be used like that. This also has
the nice side effect of getting rid of another global, which appear to be
unloved within MediaWiki developers (IMO for good reasons).

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

Wikibugs-l mailing list

Reply via email to