https://bugzilla.wikimedia.org/show_bug.cgi?id=12070

Platonides <platoni...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |platoni...@gmail.com

--- Comment #8 from Platonides <platoni...@gmail.com> 2011-02-21 23:18:36 UTC 
---
User creation is done inside maintenance/users.sql using GRANT ALL PRIVILEGES
ON 
$db TO $wgDBuser IDENTIFIED BY $pass;

http://dev.mysql.com/doc/refman/5.1/en/grant.html
> When the IDENTIFIED BY clause is present and you have global grant 
> privileges, 
> the password becomes the new password for the account, even if the account 
> exists and already has a password. With no IDENTIFIED BY clause, the account 
> password remains unchanged. 

It should instead use CREATE USER where "An error occurs if the account already
exists". http://dev.mysql.com/doc/refman/5.1/en/create-user.html

If the CREATE USER for any of the three accounts already exist, it should
abort.

It could still mask a user with the same name but different host, but manually
performing queries to mysql.user doesn't look nice (we should at least skip any
error on doing so).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to