https://bugzilla.wikimedia.org/show_bug.cgi?id=27669

Krinkle <krinklem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krinklem...@gmail.com

--- Comment #6 from Krinkle <krinklem...@gmail.com> 2011-03-08 09:21:53 UTC ---
(In reply to comment #1)

> I tried overriding the edit page CSS on MediaWiki:Common.js/edit.js:
> mw.util.addCSS( '#siteSub, #contentSub { display:none; }' );
> 
> Unfortunately this causes the divs to disappear after they have been 
> displayed,
> causing an annoying page jump, so I reverted the change.

CSS shouldn't be added with JavaScript, that will always make a delay. It
should be done in CSS. 

Although I get that edit pages cannot be identified (yet) from a CSS selector
in-core, the best solution imho is to add a class to <html> at the top of
MediaWiki:Common.js (not in a domready wrap):

if ( $.inArray(wgAction,['edit','submit']) != -1 ) {
document.getElementsByTagName('html')[0].className += ' action-edit'; }

And in MediaWiki:Common.css:

.action-edit  #siteSub, .action-edit  #contentSub { display: none; }

That will make it slighty faster than adding a <style>-element to the <head> in
a script that is loaded after later ( MediaWiki:Common.js/edit  )

See also bug 4438, which requests to add this in-core with no dependancy on
client-side scripting.



(In reply to comment #5)
> Interestingly, it looks like most wikis don't even use the subtitle
> functionality, so this would mainly just affect the English Wikipedia.

What about non-WMF wikis ?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to