https://bugzilla.wikimedia.org/show_bug.cgi?id=28202
--- Comment #3 from Mark Clements (HappyDog) <[email protected]> 2011-03-23 14:05:19 UTC --- We should modify the way we store the diff in the DB, so that an empty string is stored for genuine empty diffs, but that NULL is stored for error conditions. NULL values should be retried when running svnImport, whilst blank values should be skipped as they are valid. We could maybe even go one step further and store the error code in the DB (if we can guarantee that this won't conflict with a valid diff string, which I think we can). If we do this then it will give better reporting in the interface, and we can decide whether to retry in a more sensible manner (e.g. DIFFRESULT_TooManyPaths probably isn't worth a retry, unless $wgCodeReviewMaxDiffPaths has changed). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
