https://bugzilla.wikimedia.org/show_bug.cgi?id=13163
Tim Starling <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #15 from Tim Starling <[email protected]> 2011-03-25 01:40:17 UTC --- There are some style issues which anyone could fix up, like using English for variable names: $parlv = substr_count($this->ptitle->getPrefixedText(), '/'); whitespace, lack of line breaks where there should be line breaks: switch( strtolower( $options['showpath'] ) ) { case 'no': $this->showpath = 'no'; break; ... if( $this->mode != 'bar' ) $pn = $this->token . $pn; Also, it uses non-portable, unnecessary SQL identifier quoting: $options['ORDER BY'] = '`page_title`' . $order; ... $conditions[] = '`page_title` ' . $dbr->buildLike( $parent . '/', $dbr->anyString() ); It uses Parser::parse() when it should be using Parser::recursiveTagParse(). This is an efficiency issue, since parse() does link existence checks immediately, whereas recursiveTagParse() defers them until the next batch. It's also a correctness issue, since recursiveTagParse() guards certain syntax elements against reinterpretation, whereas parse() does not. Otherwise it should be OK to enable. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
