https://bugzilla.wikimedia.org/show_bug.cgi?id=28070
--- Comment #12 from Roan Kattouw <[email protected]> 2011-03-27 13:44:15 UTC --- (In reply to comment #7) > My concern is there are other uses of getParameterFromSettings() that > rely on timestamps being converted to TS_MW format. If the case 'timestamp' > code is changed to call $this->getDB()->timestamp(), who knows what other code > will break. > Yeah, so that shouldn't be done. Instead, the watchlist code should convert the timestamp. > That is why someone who understands the API classes and their uses needs to > determine whether a change to the APIBase abstract class method code is the > correct way to fix this bug. It's not. API modules cannot rely on the timestamp format returned by getParameterFromSettings() being TS_MW (or anything else, for that matter), they should *always* convert it to the desired format with wfTimestamp(). > Are you that person? I'd say I'm one of them. I used to be the primary API dev for two years. > Are there uses of > getParameterFromSettings() that are for purposes other than an ultimate call > to > a db select? > I'm sure there are. > Obviously, I could just change the code according to your suggestion, but I > would only test the RSS/Watchlist case. I wouldn't know if the fix breaks > other > things. I was talking about converting the timestamp in the watchlist module (which is what Bryan did in his fix), not converting it in getParameterFromSettings(). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
