https://bugzilla.wikimedia.org/show_bug.cgi?id=27566

Derk-Jan Hartman <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #7 from Derk-Jan Hartman <[email protected]> 2011-03-28 21:01:12 
UTC ---
The window consistently grows with 40px, this is the size of the left and right
margin of ".wikiEditor-toolbar-dialog .ui-dialog-content"

When you reopen the dialog, it tries to reuse the last known width of the
window.
It does this in jquery.wikiEditor.dialogs.js resize()

For instance: Initial opening of table dialog:

"ui-dialog ui-widget ui-widget-content ui-corner-all wikiEditor-toolbar-dialog
ui-draggable"
width:590px
scrollWidth:590px

#wikieditor-toolbar-table-dialog ".wikiEditor-toolbar-dialog
.ui-dialog-content"
width: auto (550)
scrollWidth: 590
clientWidth: 590

Resize function: this == #wikieditor-toolbar-table-dialog
oldWidth (of the wrapper .uidialog): 590px
thisWidth (from $this data object): 0 (not set before), using scrollWidth of
this (590)

Than we set the width of this to thisWidth and store it in the data. The width
of #wikieditor-toolbar-table-dialog now grows from 550px to 590px. The
scrollWidth of wrapper grows to 630px;

wrapperWidth: (from this data object): 0 (not set before), using scrollWidth of
wrapper (630px)
setting width of wrapper to wrapperWidth, storing wrapperWidth in data



2nd iteration

"ui-dialog ui-widget ui-widget-content ui-corner-all wikiEditor-toolbar-dialog
ui-draggable"
width:630px
scrollWidth:630px

#wikieditor-toolbar-table-dialog ".wikiEditor-toolbar-dialog
.ui-dialog-content"
width: auto (590)
scrollWidth: 630
clientWidth: 630

Resize function: this == #wikieditor-toolbar-table-dialog
oldWidth (of the wrapper .uidialog): 630px
thisWidth (from $this data object): 590px, but overwrite with scrollWidth which
is 630px

Than we set the width of this to thisWidth and store it in the data. The width
of #wikieditor-toolbar-table-dialog now grows from 590px to 630px. The
scrollWidth of wrapper grows to 670px;

wrapperWidth: (from this data object): 630, using scrollWidth of wrapper
(670px)
setting width of wrapper to wrapperWidth, storing wrapperWidth in data

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to