https://bugzilla.wikimedia.org/show_bug.cgi?id=28326
Summary: UploadStash / Uploads : stashed entries not deleted,
stash entry not deleted when file is
Product: MediaWiki
Version: wikimedia-deployment
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: Normal
Component: Uploading
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected]
In a standard Upload (as derived from UploadBase), there is an mTempPath which
represents where PHP was storing the tmpnam from its upload. When the paths are
initialized, it may be set to be deleted once the file is copied to the Repo.
According to the current scheme, an UploadFromStash will configure things such
that the stash file is the "temporary" file, and the same thing happens. Except
it's configured to not be deleted. Why?
Also, since we let the Upload delete the file in an ordinary manner, the stash
entries may persist after their files are deleted. This seems wrong too.
To fix this, we would have to get the main Upload object to invoke a delete
method on UploadStash, rather than relying on the path of the UploadStash file
being on the same machine, and being deletable. So that seems better for many
reasons -- it's more abstract and has a better chance of working with other
file stores than NFS.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
