https://bugzilla.wikimedia.org/show_bug.cgi?id=28354
Summary: Edit tab is shown as "view source" for blocked users,
which breaks squid caching
Product: MediaWiki
Version: 1.18-svn
Platform: All
URL: http://de.wikipedia.org/w/index.php?oldid=87148073#Sei
tenschutz_-_oder_doch_nicht.3F
OS/Version: All
Status: NEW
Severity: normal
Priority: Normal
Component: User interface
AssignedTo: [email protected]
ReportedBy: [email protected]
Created attachment 8355
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8355
Proposed fix: Skip user block checks for Title::quickUserCan()
In 1.16, unprotected pages showed an "edit" tab to the user, even if he was
blocked from editing. In 1.17 this behavior has accidentally changed to show a
"view source" tab for blocked users. This is problematic because the page is
then cached in squid and shown to other, non-blocked users with the wrong tab.
The change has been caused by r65504, when
Title::getUserPermissionsErrorsInternal (which is called for quickUserCan) was
refactored to also check for user blocks. The attached patch fixes this by
skipping the block checks for Title::quickUserCan. Note that the patch also
removes an unnecessary check for "$short && count($errors)", this is handled by
getUserPermissionsErrorsInternal() already.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
