https://bugzilla.wikimedia.org/show_bug.cgi?id=28378
Bug #: 28378
Summary: Do static analysis on REL1_17
Product: MediaWiki
Version: 1.17
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Normal
Component: General/Unknown
AssignedTo: [email protected]
ReportedBy: [email protected]
Blocks: 26676
Classification: Unclassified
reedy@ubuntu64-esxi:~/mediawiki/branches/REL1_17$ find phase3/ \( -name \*.php
-or -name \*.inc \) -not \( -name importUseModWiki.php -o -name
diffLanguage.php -o -name LocalSettings.php -o -name Parser?????.php \) -exec
php tools/code-utils/check-vars.php \{\} +
Could not open input file: tools/code-utils/check-vars.php
reedy@ubuntu64-esxi:~/mediawiki/branches/REL1_17$ find phase3/ \( -name \*.php
-or -name \*.inc \) -not \( -name importUseModWiki.php -o -name
diffLanguage.php -o -name LocalSettings.php -o -name Parser?????.php \) -exec
php ~/mediawiki/trunk/tools/code-utils/check-vars.php \{\} +
Problems in phase3/includes/api/ApiParse.php:
Unused global $wgEnableParserCache in function execute line 68
Problems in phase3/includes/api/ApiUnblock.php:
Use of unknown class IPUnblockForm in line 78
Problems in phase3/includes/api/ApiMain.php:
Global variable $wgAPICacheHelp is not present in DefaultSettings
Problems in phase3/includes/LocalisationCache.php:
return in line 211 is not preceded by wfProfileOut
return in line 231 is not preceded by wfProfileOut
Problems in phase3/includes/db/DatabasePostgres.php:
Global variable $wgDBts2schema is not present in DefaultSettings
Problems in phase3/includes/db/Database.php:
Global variable $title in line 2990, function fileCachedPage does not follow
coding conventions
Problems in phase3/includes/json/FormatJson.php:
Use of undefined constant SERVICES_JSON_LOOSE_TYPE in line 48
Problems in phase3/includes/resourceloader/ResourceLoader.php:
Global variable $wgResourceLoaderMinifyJSVerticalSpace is not present in
DefaultSettings
Problems in phase3/includes/ForkController.php:
Global variable $wgCaches is not present in DefaultSettings
Problems in phase3/includes/media/Bitmap.php:
return in line 257 is not preceded by wfProfileOut
return in line 260 is not preceded by wfProfileOut
Reached end of BitmapHandler::transformImageMagick with last statement not
being wfProfileOut
return in line 290 is not preceded by wfProfileOut
return in line 292 is not preceded by wfProfileOut
Reached end of BitmapHandler::transformCustom with last statement not being
wfProfileOut
Problems in phase3/includes/media/SVG.php:
return in line 123 is not preceded by wfProfileOut
return in line 125 is not preceded by wfProfileOut
Reached end of SvgHandler::rasterize with last statement not being
wfProfileOut
Problems in phase3/includes/media/DjVu.php:
return in line 120 is not preceded by wfProfileOut
return in line 122 is not preceded by wfProfileOut
Reached end of DjVuHandler::doTransform with last statement not being
wfProfileOut
return in line 181 is not preceded by wfProfileOut
Problems in phase3/includes/Profiler.php:
return in line 347 is not preceded by wfProfileOut
Reached end of Profiler::getFunctionReport with last statement not being
wfProfileOut
Problems in phase3/includes/Hooks.php:
return in line 169 is not preceded by wfProfileOut
return in line 192 is not preceded by wfProfileOut
return in line 196 is not preceded by wfProfileOut
Reached end of ::wfRunHooks with last statement not being wfProfileOut
Problems in phase3/includes/specials/SpecialUploadStash.php:
Unused global $wgOut in function execute line 59
Problems in phase3/includes/specials/SpecialImport.php:
$wgOut marked as global again in line 60, function execute
Problems in phase3/includes/specials/SpecialActiveusers.php:
Use of unknown class UsersPager in line 33
Problems in phase3/includes/upload/UploadBase.php:
Empty statement
Problems in phase3/includes/installer/Installer.php:
Unused global $wgHooks in function __construct line 307
Did not found the expected require of
/home/reedy/mediawiki/trunk/tools/code-utils/../../phase3//AdminSettings.php
$wgHooks is used as local variable in line 1206, function includeExtensions
$wgHooks is used as local variable in line 1207, function includeExtensions
Unused global $wgAutoloadClasses in function includeExtensions line 1199
Problems in phase3/includes/User.php:
Global variable $wgLogAutocreatedAccounts is not present in DefaultSettings
Problems in phase3/includes/Profiler.php:
return in line 347 is not preceded by wfProfileOut
Reached end of Profiler::getFunctionReport with last statement not being
wfProfileOut
Problems in phase3/includes/Article.php:
return in line 1847 is not preceded by wfProfileOut
Reached end of Article::incViewCount with last statement not being
wfProfileOut
Problems in phase3/includes/ObjectCache.php:
Global variable $wgCaches is not present in DefaultSettings
Problems in phase3/includes/Skin.php:
Unused global $wgRestrictionTypes in function makeGlobalVariablesScript line
425
Problems in phase3/includes/MessageCache.php:
Global variable $wgContLanguageCode is not present in DefaultSettings
Problems in
/home/reedy/mediawiki/trunk/tools/code-utils/../../phase3//maintenance/doMaintenance.php:
Did not found the expected require of
/home/reedy/mediawiki/trunk/tools/code-utils/../../phase3//AdminSettings.php
Problems in phase3/languages/Language.php:
Reached end of Language::getMagic with last statement not being wfProfileOut
Problems in phase3/maintenance/minify.php:
Global variable $wgResourceLoaderMinifyJSVerticalSpace is not present in
DefaultSettings
Problems in phase3/maintenance/benchmarkPurge.php:
Did not found the expected require of phase3/maintenance/DO_MAINTENANCE
Problems in phase3/maintenance/upgrade1_5.php:
Poisoned function create_function called from copyTable in line 340:
create_function should be avoided. See
http://www.mediawiki.org/wiki/Security_for_developers#Dynamic_code_generation
Problems in phase3/maintenance/fuzz-tester.php:
Poisoned function create_function called from makeTitleSafe in line 810:
create_function should be avoided. See
http://www.mediawiki.org/wiki/Security_for_developers#Dynamic_code_generation
Problems in phase3/maintenance/tests/parser/parserTestsParserHook.php:
Poisoned function var_dump called from hook in line 38: Debugging function.
Problems in phase3/maintenance/tests/parser/parserTest.inc:
Poisoned function var_dump called from fuzzTest in line 244: Debugging
function.
Problems in phase3/maintenance/tests/RunSeleniumTests.php:
Did not found the expected require of phase3/maintenance/tests/DO_MAINTENANCE
Problems in phase3/maintenance/language/generateCollationData.php:
Did not found the expected require of
phase3/maintenance/language/DO_MAINTENANCE
Problems in phase3/profileinfo.php:
Global variable $sort in line 186, function compare_point does not follow
coding conventions
Global variable $filter in line 252, function getEscapedProfileUrl does not
follow coding conventions
Global variable $sort in line 252, function getEscapedProfileUrl does not
follow coding conventions
Global variable $expand in line 252, function getEscapedProfileUrl does not
follow coding conventions
We seem to have a few little merge errors, and such
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
