https://bugzilla.wikimedia.org/show_bug.cgi?id=28511
Bug #: 28511
Summary: Cleanup use of {} for string character access
Product: MediaWiki
Version: 1.18-svn
Platform: All
OS/Version: All
Status: NEW
Severity: trivial
Priority: Normal
Component: General/Unknown
AssignedTo: [email protected]
ReportedBy: [email protected]
Classification: Unclassified
Right now, we use {} in a small handful of places to access particular
characters in a string. This was and remains valid in PHP. However, for the
time PHP6 was on the table, this syntax was deprecated. Who knows when PHP
might decide to deprecated it again.
Our coding style prefers [], and for consistency we should stick with one or
the other. Since {} was at one time deprecated and may be again, let's use the
former.
Biggest offenders:
json/Services_JSON.php
normal/UtfNormal.php
I think \$[a-z_]+[a-z0-9_]*\{ catches them all with just a few false positives
in the language files you can rule out.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
