https://bugzilla.wikimedia.org/show_bug.cgi?id=28076
--- Comment #11 from Bryan Tong Minh <[email protected]> 2011-04-26 08:07:11 UTC --- (In reply to comment #10) > This patch seems to have two parts: > * fix Special:Listfiles specifically to use a maximum box height (easy > one-line > fix) Correct, that is indeed only the one line change to SpecialListfiles.php > * a general change to thumbnailing box sizing Correct, that should fix the bug that is present on http://test.wikipedia.org/wiki/Bug_28076 > Is that general change to ensure to that we have a minimum width and height of > 1? Will it affect anything else? Does our resizing code that tries to match > ImageMagick need adjusting? The change ensures a minimum width of 1 pixel. As for ImageMagick, we specify the exact size, not the shrink factor, so that should not be a problem. I just ran parserTests and it appears that some errors appear which may be due to this patch. I could just commit the SpecialListfiles.php patch and open a new bug for the thumbnail sizing bug... They are two only indirectly related bugs. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
