https://bugzilla.wikimedia.org/show_bug.cgi?id=28983
--- Comment #3 from T. Gries <[email protected]> 2011-05-15 23:04:50 UTC --- (In reply to comment #2) > The bug summary kind of sucks No, the bug sucks, not the summary. Let me explain, why. It's a typical problem like in parsing. The installer first detects some extensions present during the installation process and adds some "require" directives for those extensions the user wants to be installed: example: # Enabled Extensions. Most extensions are enabled by including the base extension file here # but check specific extension documentation for more details # The following extensions were automatically enabled: require( "extensions/OpenID/OpenID.php" ); require( "extensions/LiquidThreads/LiquidThreads.php" ); Then - and not earlier - the hook(-targets) in the extensions are activated; a subsequent run of php update.php _would_ trigger the active "require"s and therefore the hooked database update processes. I admit, that an automated "php update.php" is strange and might be dangerous. But please consider the following scenario: User downloads Mediawiki. User added "LiquidThreads" and "OpenID" extension. User ran the installation procedure, which correctly detected presence of the two extensions. User actived the two checkboxes of the installation process. Installer added the the two "require" lines in LocalSettings.php. User downloaded and installed the LocalSettings.php successfully and started the Wiki. The Wiki STALLS. Because the extensions require an database update, which is triggered by their hooks, if the hooks can be "seen" through the extensions' calls in LocalSettings.php. Thus in my view, a typical problem and requiring either a "two-pass" installation: i) standard as now ii) if any extensions are added, then run "update.php" or show a message to the user that they must run "php update.php" if they added at least one extension during the installation process which only added the "require" statements, but did not run the update. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
