https://bugzilla.wikimedia.org/show_bug.cgi?id=29106

       Web browser: ---
             Bug #: 29106
           Summary: JavaScript still uses legacy globals etc.
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: Unprioritized
         Component: WikiEditor
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]
    Classification: Unclassified


Legacy globals:
 wgArticlePath in jquery.wikiEditor.dialogs.config.js
 wgExtensionAssetsPath in jquery.wikiEditor.iframe.js and jquery.wikiEditor.js
 wgPageName in jquery.wikiEditor.previewDialog.js and jquery.wikiEditor.toc.js
 wgScriptPath in jquery.wikiEditor.dialogs.config.js (twice) and
jquery.wikiEditor.previewDialog.js
 wgServer in jquery.wikiEditor.dialogs.config.js
 wgTitle in jquery.wikiEditor.previewDialog.js
 wgUrlProtocols in jquery.wikiEditor.dialogs.config.js
 wgUserLanguage in jquery.wikiEditor.js (twice)

$j in:
 ext.wikiEditor.preview.js
 ext.wikiEditor.publish.js
 jquery.wikiEditor.dialogs.js
 jquery.wikiEditor.js
 jquery.wikiEditor.previewDialog.js
 jquery.wikiEditor.publish.js

Accidently global variables
Firebug lists some variables in global scope which probably come from
WikiEditor and are meant to be local:
 $group
 cell
 filter
 group
 heading
 option
 page
 row
 section
 tool
 type

For-in-loops:
 Some for-in-loops (e. g. for ( filter in tool.filters ) in
jquery.wikiEditor.toolbar.js) seem to run not over an object but over an array.
Use the for (;;) form instead.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to