https://bugzilla.wikimedia.org/show_bug.cgi?id=26207
--- Comment #8 from Platonides <[email protected]> 2011-05-25 15:31:33 UTC --- Seems to do the job. Although I'm not convinced about the efficiency of using preg_match_all. Thanks for your contribution. Some notes: Do not use == null to test if the entry is present, that will produce a notice. Use isset() instead. The name of the main function (Magical::pbt) should be much clear. ISBN is not normalised. You are not providing the css classes. The callbacks are safe thanks to the limited scope of the regex. Maybe add some redundant htmlspecialchars? If you want to consider a design change, I would have used per-parser state added in ParserFirstCallInit, like parser functions and tag hooks, probably making a single combined regex there (so you don't need to scan the text N times). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
