https://bugzilla.wikimedia.org/show_bug.cgi?id=29284

--- Comment #1 from Brion Vibber <[email protected]> 2011-06-06 17:54:05 UTC 
---
A few things to consider...

It looks like the name-changing in this patch is stuffed into the AJAX license
preview code... it probably belongs over with fillDestFilename or other stuff
that's related to the filename getting set.

When dealing with reuploading new versions over existing files, we need to make
sure that the name doesn't get changed. 

Patch needs to come with test cases if possible; see tests/qunit &
http://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing for more info on
our new JavaScript testing framework.

Since it looks like this name transformation isn't currently applied on the PHP
side either, if done here it should also be done on the PHP side. This again
would need to deal with the case of existing files that violate the new
recommendation.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to