https://bugzilla.wikimedia.org/show_bug.cgi?id=29440

       Web browser: ---
             Bug #: 29440
           Summary: $().wikiEditor('removeFromToolbar') can only find
                    <span> buttons, not <img> buttons
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: WikiEditor
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]
    Classification: Unclassified


Buttons added with addToToolbar seem to create <img>s rather than <span>s, but
the removeFromToolbar function will only remove tools that are <span>s:

    target += ' span[rel=' + data.character + ']';

An img button:

    <img width="22" height="22"
src="/trunk/extensions/CodeEditor/images/code-selected.png?20110616T191440Z"
alt="&lt;codeeditor-toolbar-toggle&gt;"
title="&lt;codeeditor-toolbar-toggle&gt;" rel="codeEditor" class="tool
tool-button">

A span button:

    <span alt="Bold" title="Bold" rel="bold" class="tool tool-button
wikiEditor-toolbar-spritedButton" style="background-position: 2px
-142px;">Bold</span>

Thus this doesn't work as expected:

        $('#wpTextbox1').wikiEditor('removeFromToolbar', {
            'section': 'main',
            'group': 'format',
            'tool': 'codeEditor'
        });

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to