https://bugzilla.wikimedia.org/show_bug.cgi?id=23510

--- Comment #4 from Brion Vibber <[email protected]> 2011-06-16 21:46:44 UTC 
---
Is the issue about the "Replace all" command? If you find/replace one at a
time, doing one at a time seems about right and should be the correct thing to
do.

On my Linux desktop (FF 4.0, i5 something orother) it took about 8 seconds to
search-replace all instances of 'Illinois' on [[Obama]]; definitely longer than
I like without any progress feedback.

It looks like currently in trunk, the replace all mode does a fairly quick
match, but then runs through encapsulateSelection logic for each individual
replacement.

I guess the main alternative to that would be to perform the replacements in a
single regex on the source text, then drop that source text back into the
editor. This is probably ok for the plain textarea, but could involve reparsing
of iframe or CodeEditor stuff, which might itself be slow or fast.

It also looks like each individual replacement is doing things like changing
the scrolling, so that might be contributing to the time spent in each
replacement.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to