https://bugzilla.wikimedia.org/show_bug.cgi?id=29519
Web browser: ---
Bug #: 29519
Summary: Stomp pending processor will always run $batch_size
times if there are one or more explicitly pending
transactions
Product: Wikimedia
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Fundraising - misc
AssignedTo: [email protected]
ReportedBy: [email protected]
Classification: Unclassified
In stompPFPPendingProcessorSA.php:
If the pending queue is shorter than $batch_size, and
handle_pending_transaction() pushes one or more pending transactions back into
the pending queue, those pending transactions just get back in the queue to be
processed again in the same batch. Therefore, if one or more transactions come
back from paypal with code 126 or 26, the processor can't quit before it's
re-pulled and re-queued the pending items enough times to meet the initial
$batch_size.
The end result does not appear to be damaged by the current behavior; It's just
an efficiency problem. Ideally, if the queue is shorter than the batch size
when the processor gets kicked off, it would consume each transaction in the
queue once, and exit.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
