https://bugzilla.wikimedia.org/show_bug.cgi?id=29569
Bawolff <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fatal error: Call to a |Calling |member function getGroup() |$out->addModuleStyles( |on a non-object in |'invalid.module' ); with an |OutputPage.php on Vector |invalid module name causes |skin copy |php fatal --- Comment #3 from Bawolff <[email protected]> 2011-06-24 22:44:45 UTC --- The line you changed that broke everything is: $out->addModuleStyles( 'skins.vector' ); (In reply to comment #2) > only change words vector in css classnames, as skin name and in various var > names. and changed module/skin name to new word, also renamed directory with > css and images. Well yes, doing a global find and replace on part of the codebase is a good way to introduce bugs. Anyhow that's kind of off topic since bugzilla is not a support forum. ----- Re-purposing bug: Expected behaviour: *Calling $out->addModuleStyles( 'some.invalid.module' ); should either ignore the invalid module, or throw an exception. Actual behaviour: Fatal error: Call to a member function getGroup() on a non-object in /home/pidginet/public_html/test/includes/OutputPage.php on line 2707 I'm not sure which of ignoring or throwing an exception is better. I personally prefer throwing an exception, however (based on a quick look) scriptModules that are invalid already seem to be ignored so there is precedent that way (but this ignoring seems to be a side effect of filtering them for top/bottom, and not intentional) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
