https://bugzilla.wikimedia.org/show_bug.cgi?id=29753
--- Comment #3 from Krinkle <krinklem...@gmail.com> 2011-07-07 17:21:47 UTC --- (In reply to comment #0) > mw.util only sets this for Firefox 2. This seems to be a simple copy and paste > mistake, since in wikibits.js there is a "if ( is_ff2 )" too, but with the > comment "note that FF3+ is included here!". > > The wrong access key isn't shown since it is still handled by the function in > wikibits.js. The legacy wikibits.js code is as follows: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/wikibits.js?revision=86108&view=markup#l183 > > } else if ( is_ff2 ) { > tooltipAccessKeyPrefix = 'alt-shift-'; > } > If "is_ff2" means "ff2 or higher" then I missed that. I see the comment in the definition of window.is_ff2 now though, brion fixed that in r91652 (marking this bug as fixed). (In reply to comment #1) > Urghh... is there a reason that there are two versions of this function and > only one is used?? Yes, the reason is backwards compatibility and quarantine of the legacy library. The legacy script should not be modified neither should it be referenced/used by core. There are rewritten, modernized or otherwise succeeded versions in the mediawiki object library. if the legacy variable is used then that's a bug! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
