https://bugzilla.wikimedia.org/show_bug.cgi?id=27894
--- Comment #11 from Krinkle <[email protected]> 2011-07-08 19:40:25 UTC --- nice catc(In reply to comment #9) > Patch has several bugs: Nice catches. A few more: * Loading of module needs to be moved out of OutputPage->headElement probably * Should account for the situation in which there is no edit link on the page (ie. not bind the event, because if MediaWiki decided not to output that tab, it probably has a good reason) * There ar differences in skins in where this link will be. This is a common problem we are encountering more and more often lately (just look at the code that makes mw.util.$content and addPortletLink work, it's disguisting). Probably need to make some radical changes to skins in the future, but oh well. This can be fixed in the long term by not allowing skins to use different IDs for core elements or by requiring skins to log into a method how/where elements are) – back to the present this can be solved by either: -- exporting the edit-tab link through a config variable (alert! this is not a config variable) -- exporting it as a piece of information in the per-module configuration (sounds good, except that such a thing doesn't exist yet) -- scrapping HTML for "#ca-edit a" and not caring about other skins. -- a switch-case for all skins. The last two options will be ugly and not extendable by custom skins. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
