https://bugzilla.wikimedia.org/show_bug.cgi?id=29806
Chad H. <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Chad H. <[email protected]> 2011-07-11 14:16:12 UTC --- Just gave this extension a quick look (over in its Google code repo, it does need to be in SVN here for WMF deployment). At the very least: * uses raw $_REQUEST * Couple of global functions should be in classes -- use the autoloader rather than raw includes * using $wgParser for hook initialization The extension part of it seems reasonably sane barring these issues--again, I just looked quickly and this was not an in-depth review. I did not look at the pChart library it uses yet, that could be a whole different story. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
