https://bugzilla.wikimedia.org/show_bug.cgi?id=29835
Brion Vibber <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |WONTFIX --- Comment #5 from Brion Vibber <[email protected]> 2011-07-13 00:53:58 UTC --- 'Local consensus' link leads to a nonexistent page. Assuming this is about http://www.mediawiki.org/wiki/Extension:CustomSidebar ... Source is not in our SVN, so it would need to be copied & reviewed prior to any potential deployment. I really don't like this extension however; per-page sidebar tweaks aren't really how the sidebar's generally meant to be used, and the current sidebar syntax is sufficiently *horrible* to use that I really really wouldn't want to start hardcoding that in more places. The system for pulling the sidebar info from the page seems to explicitly deal with parser caching not by using MediaWiki's own systems (for instance, saving the relevant information with the ParserOutput object and then pulling it out from the cached object) but by simply hiding the sidebar chunk in the parsing, then during the skin's sidebar processing it *expands templates and variables, strips comments, finds the sidebar chunk, and then processes that. THis feels very.... icky! It also seems to interact with $wgEnableSidebarCache by .... saving a single sidebar cache per language for the entire site. This seems like it will not actually work? I definitely recommend against this extension or anything that works like it does. If custom sidebar lines need to be added in only a few specific cases, you can do this now using site JS to conditionally append items to the sidebar (or site CSS to conditionally show/hide a line based on page title or a couple other things). If there's a real, specific need that's different, please go into details about the actual requirements and we'll see whether something that fits Wikimedia's performance and security needs better without messing anything up could be devised. (Personally I would recommend against anything along these lines though.) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
