https://bugzilla.wikimedia.org/show_bug.cgi?id=29854
--- Comment #1 from Brion Vibber <[email protected]> 2011-07-13 17:32:07 UTC --- To my great pleasure, wfMakeUrlIndex does not appear to explode on these on trunk: > return wfMakeUrlIndex('http://foobar.com/baz/quux'); http://com.foobar./baz/quux > return wfMakeUrlIndex('//foobar.com/baz/quux'); //com.foobar./baz/quux However it *does* explode on them in 1.17 and 1.18: > return wfMakeUrlIndex('//foobar.com/baz/quux'); PHP Notice: Undefined index: scheme in /var/www/rel1.18/includes/GlobalFunctions.php on line 2716 PHP Stack trace: PHP 1. {main}() /var/www/rel1.18/maintenance/eval.php:0 PHP 2. eval() /var/www/rel1.18/maintenance/eval.php:79 PHP 3. wfMakeUrlIndex() /var/www/rel1.18/maintenance/eval.php(79) : eval()'d code:1 PHP 4. wfParseUrl() /var/www/rel1.18/includes/GlobalFunctions.php:2740 PHP Notice: Undefined index: scheme in /var/www/rel1.18/includes/GlobalFunctions.php on line 2718 PHP Stack trace: PHP 1. {main}() /var/www/rel1.18/maintenance/eval.php:0 PHP 2. eval() /var/www/rel1.18/maintenance/eval.php:79 PHP 3. wfMakeUrlIndex() /var/www/rel1.18/maintenance/eval.php(79) : eval()'d code:1 PHP 4. wfParseUrl() /var/www/rel1.18/includes/GlobalFunctions.php:2740 ./ Probably need to backport the updates to that function (I recall fixes related to file: URLs, which probably fixed this as a side effect). However a bigger problem is that even if you can get them past the UI on the external links search page, this forces you to *know* whether you're looking for an http-only, an https-only, or a protocol-independent URL. A possible way to make these work 'naturally' might be to actually change how we save external URLs into the table... instead of saving one entry without a protocol, we could save *two* entries -- one http and one https. This would allow either to be searched for, but would also list both if fetching lists of external links for a given page. Which seems legit, to be honest. ;) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
