https://bugzilla.wikimedia.org/show_bug.cgi?id=9838
--- Comment #9 from Platonides <[email protected]> 2011-07-17 13:34:29 UTC --- A few minor issues: I guess you are using "if ( is_array( $wgFailedPasswordAttemptNotifcation ) ) {" so that it could be disabled with $wgFailedPasswordAttemptNotifcation = false; or something similar. Please document. New messages have to be added to maintenance/language/messages.inc Do not use magic values as 172800 (48h) Use tabs, not spaces. There's a mising } at notifyUser (line 839) The code will not send an email if there is one check at epoch X, three more at X + 172780, then four at X + 172810 (7 checks in 30 seconds). Is this expected? Now about the content: I am not sure about the email sent. What do we expect the people on {{SITENAME}} to do? A sysadmin could filter it on the firewall, but not a sysop. This is not able to detect attacks from several ips (eg. a botnet), although our throttling has the same limitation. Could this have implications with WMF privacy policy? (for WMF sites) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
