https://bugzilla.wikimedia.org/show_bug.cgi?id=30051
Reedy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |need-review --- Comment #1 from Reedy <[email protected]> 2011-07-25 17:00:37 UTC --- For starters, the code has quite a lot of raw SQL building, there seems to be some nested SQL statements in SpecialCollabWatchlist.php, which are a no-no while we still have MySQL 4 boxes in the cluster while( $row = $res->fetchObject() ) { is old coding style, use foreach( $res as $row ) { $dbr->freeResult( $res ); isn't needed CollabWatchlist.js doesn't seem to be used anywhere, and hence doesn't load it using the ResourceLoader The extension doesn't follow our Coding Style guidelines [1] The code could benefit from having proper fleshed out function level comment blocks [1] http://www.mediawiki.org/wiki/Manual:Coding_conventions -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
