https://bugzilla.wikimedia.org/show_bug.cgi?id=27757

--- Comment #12 from John Du Hart <[email protected]> 2011-07-29 15:12:29 UTC 
---
(In reply to comment #11)
> I think Brian is possibly just meaning ApiQueryInfo->getTokenFunctions()

Yup, I know.

> So that we're not hardcoding the token types, and keep it somewhat dynamic, so
> other modules can add their own without having to change the core modules...

The point is that if people are hooking into it right now their custom getToken
functions are expecting a pageid and Title. Just blindly going with this and
sending off null or a random page could have odd side effects

> Having said that, non of the getToken functions actually use either of the
> parameters....

Then maybe we should move those functions to ApiTokens create a new hook for
tokens that don't need page info, and fix ApiQueryInfo to use that.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to