https://bugzilla.wikimedia.org/show_bug.cgi?id=9767
--- Comment #79 from D J Bauch <dj.ba...@gmail.com> 2011-07-29 22:35:30 UTC ---
(In reply to comment #78)
> So that "MSSQL native" thing is obsolete and everybody should use PDO? Should
> we throw away our current MSSQL backend that bitrots for a year now? A few
> quick comments on attached code:
> 1) We don't accept patches with new functionality against released versions.
> Only trunk. And for such complex things, we don't accept patches at all.
> Instead, we give commit access to people interested in continuously
> maintaining
> these.
> 2) Database class is a legacy alias for DatabaseMysql, inherit from
> DatabaseBase.
> 3) Code duplication in constructor and newFromParams().
> 4) wfProfileIn("dbconnect-$server") is superfuluous, no heavy operations
> between it and parent wfProfileIn(__METHOD__).
> 5) Due to (2), you have to resort to overloading query() and performing messy
> manual SQL rewrites, don't do that. Change SQL abstraction functions instead.
> 6) Same thing for copy-paste inheritance of virtually every function.
> 7) Manual magic quotes fighting in strencode() and qstr() is not needed,
> magic_quotes_gpc is handled in WebRequest while installer refuses to install
> with magic_quotes_runtime on.
> 8) Lots of commented-out code.
> 9) Code doesn't follow our coding conventions outlined at
> http://www.mediawiki.org/wiki/Manual:Coding_conventions
Thanks for those comments. I'll endeavor to fix those issues. As to MSSQL
native, I never have used that. I haven't had any luck getting that or PDO for
SQL Server working on Windows XP, so I used the ADODB library in the past. I
started on the PDO driver by making a copy of my old ADODB driver code, so that
explains some of the legacy stuff that now needs to be cleaned up. MSSQL native
and PDO work fine for me on Windows 7 and on Windows Azure, and with SQL Azure.
ADODB doesn't do as well with SQL Azure, so right now I either use ADODB on XP
with SQL Server 2005 or 2008 or I use PDO on Windows 7 or Azure with SQL Server
2005, 2008, Denali, or Azure
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
