https://bugzilla.wikimedia.org/show_bug.cgi?id=29396
--- Comment #3 from John Du Hart <[email protected]> 2011-08-23 23:35:05 UTC --- Patch applied in r95351. A few notes though > + if ($namespace != null) { Our coding conventions prefer spaces (http://www.mediawiki.org/wiki/Coding_convention#Spaces) inside of parentheses. Also, when checking if a value is null you should use an identical comparison operator, just to be safe (http://www.mediawiki.org/wiki/Coding_convention#PHP_pitfalls) I also swapped out the foreach+switch statement in the api module for a simpler if statement. > + ApiBase::dieDebug( __METHOD__, "Unknown prop=$p" ); You don't have to worry about these things, the API will throw a warning about it and remove it from the array :) Also in the append functions I removed the $property argument, because it was unused. Very good patch though Beau, thank you for taking the time to do this. :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
