https://bugzilla.wikimedia.org/show_bug.cgi?id=30611
--- Comment #16 from Siebrand <[email protected]> 2011-08-31 17:24:06 UTC --- Some quick notes of review I requested on IRC: RoanKattouw: + // The core 28-letter alphabet, special letters for the Arabic language, [5:15p] RoanKattouw: Use tabs not spaces for indentation [5:15p] RoanKattouw: "\u0627", "\u0628", "\u062a", [5:15p] Krinkle: I'd recommend using [diacritic, dottedCircle(diacritic)] [5:15p] RoanKattouw: Random tab in the middle of a line [5:15p] Krinkle: eh, the other way around of course [5:15p] Krinkle: ie. not let it return an array [5:16p] Krinkle: To be more flexible. Otherwise rename the function [5:16p] RoanKattouw: siebrand: Patch looks fine otherwise -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
