https://bugzilla.wikimedia.org/show_bug.cgi?id=5491
John Du Hart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5559|0 |1 is obsolete| | --- Comment #11 from John Du Hart <[email protected]> 2011-09-01 03:15:32 UTC --- Comment on attachment 5559 --> https://bugzilla.wikimedia.org/attachment.cgi?id=5559 Second Revision of the Patch with no colors but borders used Thanks for submitting a patch to MediaWiki. Unfortunately I'm going to have to mark them as obsolete because they no longer merge into our current code. However I would like to touch on two things about the patch: 1. MediaWiki has a strict guideline on how code should be formatted. Mainly, single line if statements are highly discouraged as they aren't very readable. http://www.mediawiki.org/wiki/Manual:Coding_conventions 2. The following code is worrying User::newFromId($revUserId)->getGroups() Although it may not look like much it can possibly add a large amount of Queries to the page. You're loading up a user object which requires a separate database query for each revision. Ouch. If you were to re-implement this today you should look at creating a JOIN in the query to get user groups Thank you very much though for submitting this patch, any bit helps. =) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
