https://bugzilla.wikimedia.org/show_bug.cgi?id=30650

--- Comment #11 from Krinkle <[email protected]> 2011-09-02 20:27:26 UTC ---
(In reply to comment #9)
> (In reply to comment #7)
> > Before I continue review, what is the intended/required browser support of
> > MobileFrontend ?
> > 
> > I see a few problems in the JavaScript that aren't problems in the "perfect
> > browser", but are in IE, Opera or old verisons of Firefox.
> 
> Ideally we would want to support those browsers as well. But, it is mostly
> geared towards mobile based browsers.

I used those names as examples, but of course we're talking about mobile
browser here. Sadly, mobile browsers are even 'worse' than desktop browser when
it comes to consistency in support of JavaScript APIs. 

I understand you likely won't have a huge table with support for MobileFrontend
yet, since it's still in development and what is supported partially depends on
what it actually can work on. (ie. we support as much as possible, and if it
happens to work in X, then X could be added to the list of supported mobile
devices). But it would helpful in review, if there is at least some kind of
list with mobile devices that it must work on.

When I started reviewing, one problem came up already. The script tries to read
the 'display' property of the 'style' property of the dom element node for the
#logo. That works fine in Mobile Safari or Google Chrome, but not in Internet
Explorer on pocket-pcs, pdas or phones running Microsoft software with Internet
Explorer (up to a certain version).

In some versions of internet explorer:
var a = document.createElement( 'div' ); a.style.display // does not give
'block'
Instead it has to be computed via getComputedStyle.

And there are more issues like this, hence the existence of jQuery and other
libraries.

I'm happy to further review this script, and on first glance it works fine in a
'perfect' browser like Mobile Safari or Google Chrome. But assuming this is not
just intended for Android and iPhone, I need to know which browsers/devices it
must run on and as such which problems (that are really problems in those
browsers) we need to fix.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to