https://bugzilla.wikimedia.org/show_bug.cgi?id=30792

       Web browser: ---
             Bug #: 30792
           Summary: Protocol-relative URLs cause complete breakage of
                    Squid purge during upload, action=purge, etc.
           Product: MediaWiki
           Version: 1.17
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: Unprioritized
         Component: Uploading
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]
    Classification: Unclassified


In LocalFile: purgeCache(), purgeThumbnails() and recordUpload2() all call
SquidUpdate::purge(), and apparently the URLs in all three cases are
potentially protocol-relative. SquidUpdate has always had support for purging
relative URLs, it calls SquidUpdate::expand(), but this function has not been
updated to support protocol-relative URLs, so the result is invalid. HTCP
packets with URLs like the following have been logged:

//commons.wikimedia.org//upload.wikimedia.org/wikipedia/commons/thumb/0/03/Laurel_Caverns_cave.jpg/1024px-Laurel_Caverns_cave.jpg

Users are complaining. I'm going to look at doing a quick live patch.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to