https://bugzilla.wikimedia.org/show_bug.cgi?id=30011
--- Comment #7 from Yaron Koren <[email protected]> 2011-09-08 16:40:02 UTC --- Hi LY, Sorry for the delay - and thanks again for this awesome patch. I finally checked it in to SVN just now, with some modifications: I moved the new functions into SF_FormPrinter.php, so now that's the only modified file; I changed the names of some of the functions and variables; I changed the parameter "embedder" to now be called "holds template"; I changed some of the comments and formatting; and I did some refactoring of the code, creating a new function, multipleTemplateInstanceHTML(). But the actual flow of the code is exactly as you created it. This looks great, and I think this will have a big impact on how forms are structured. There's only one problem that I see with it at the moment, which is that, if you have a "label=" parameter for the multiple-instance template (which many people do), the <fieldset> tag for that template doesn't move to the new location in the form. You can see the problem here, with this test form I created: http://discoursedb.org/wiki/Special:FormEdit/Source2/Test_source Here's the definition of that form: http://discoursedb.org/w/index.php?title=Form:Source2&action=edit Do you have any thoughts on this? If you know of a fix, another patch would definitely be welcome. -Yaron -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
