https://bugzilla.wikimedia.org/show_bug.cgi?id=19516
--- Comment #4 from Brion Vibber <[email protected]> 2011-09-15 01:24:59 UTC --- Ahh I think I see what's happening. The headers etc which use the user setting are showing correctly -- it's the {{REVISIONTIMESTAMP}} that renders wrong. {{REVISIONTIMESTAMP}} uses the server-wide timezone setting, which looks like it's getting incorrectly set still through an old old system which only grabs the current offset -- so at the moment we're actually using '120 minutes offset' instead of 'Europe/Berlin' as the server default. D'oh! Edited after end of summer time: http://de.wikipedia.org/w/index.php?oldid=52264210 shows: • header UTC: 2008-10-26 um 13:01:15 • header set to Europe/Berlin: 2008-10-26 um 14:01:15 <- +1 RIGHT • REVISIONTIMESTAMP: 20081026150115 <- +2 WRONG Edited during summer time: http://de.wikipedia.org/w/index.php?oldid=52230987 shows: • header UTC: 2008-10-25 um 16:14:28 • header set to Europe/Berlin: 2008-10-25 um 18:14:28 <- +2 RIGHT • REVISIONTIMESTAMP: 20081025181428 <- +2 RIGHT This bit in CommonSettings.php needs to be removed: if ( !isset( $wgLocaltimezone ) ) $wgLocaltimezone = 'UTC'; # Ugly hack warning! This needs smoothing out. if ( $wgLocaltimezone ) { $oldtz = getenv( 'TZ' ); putenv( "TZ=$wgLocaltimezone" ); $wgLocalTZoffset = date( 'Z' ) / 60; putenv( "TZ=$oldtz" ); } ... and alas similar code appears to be in Setup.php now. :P Language::userAdjust's path through 'System' or tz being '' should probably be pulled up and run through the date_create / date_timezone_set stuff if $wgLocaltimezone is set, preferable to $wgLocalTZOffset. Or at least they need to be sorted out in some way. :P -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
