https://bugzilla.wikimedia.org/show_bug.cgi?id=30803

--- Comment #6 from darklama <[email protected]> 2011-09-18 17:39:56 UTC ---
(In reply to comment #5)
> Assigning to myself to review and commit later.
> 
> Note to self:
> * Base could have a ? already (see wfAppendQuery)
> * Add tests for cases where base has ?, as well as for action paths on
> combination with only passing title, only action, only extra query, and
> combinations.
> * Perhaps possible without needing a decode function

I think assuming "?" at the end of page means a query string is an error.
I believe wikiGetlink is intended to expand the page parameter in basically
the same way as [[Page]] does, which includes encoding "?". If that is not
done than wikiGetlink won't be able to be used for pages which include a
"?" in their name.

Though come to think of it, I didn't check for section anchors. Those need
to be encoded differently. A check for the case where an anchor without
a title is used is needed too.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to