https://bugzilla.wikimedia.org/show_bug.cgi?id=29357
--- Comment #5 from Niklas Laxström <[email protected]> 2011-09-19 17:26:33 UTC --- The patch looks fine. Few notes though: * array_push is not commonly used when appendin elements to array. The shorthand $array[] = $elem; is much more common. * It lacks some whitespace according to your style guide. Do you know /trunk/tools/code-utils/stylize.php? * I see that the div has dir depending on the interface language, but has literate RLM/LRM marker in content language inside, is that correct? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
