https://bugzilla.wikimedia.org/show_bug.cgi?id=31102
Web browser: ---
Bug #: 31102
Summary: buildTool function uses improper for loop for filters
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: WikiEditor
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: wilson.ji...@gmail.com
CC: roan.katt...@gmail.com, tpars...@wikimedia.org
Classification: Unclassified
This problem affects wikiEditor for MW 1.17 - I have not tried other versions.
In jQuery.wikiEditor.toolbar.js, the buildTool function improperly uses a
for..in loop to iterate through an array (specifically, for applying filters).
This works fine as long as nobody has added to the Array.prototype, but if they
have the for..in loop will pick up non-integer keys.
Although some JavaScript libraries shy away from making changes to prototypes,
there are plenty of legacy ones which still do.
This bug causes blocking JavaScript errors whenever an addition to
Array.prototype has a value which causes jQuery to return a wrapped array
instead of an actual jQuery collection.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
