https://bugzilla.wikimedia.org/show_bug.cgi?id=27976
Bawolff <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|need-parsertest | CC| |[email protected] --- Comment #11 from Bawolff <[email protected]> 2011-09-28 01:51:31 UTC --- My main concerns with this code are as follows: *This does existence checks (and possibly quite a few [like ~127] for weird inputs) whenever getSubpage is called. I don't know for sure, but that sounds expensive when (an abusive) user could add thousands of such things to a page (I suppose if we really wanted this we could make it an expensive parser function) *People may be (ab)using the {{SUPAGENAME}} stuff for other uses that this would break (admittedly I don't know off hand if anyone does, but we should be careful when changing these types of thing). For example {{BASEPAGE:foo/bar}} can be used to strip off everything after the / without any concern for if its a real title. (Perhaps if we really wanted it, make a new magic parser func thing for this behaviour) Minor issue: (This is just at looking at code, I haven't tested so i could of missed something). It appears this doesn't check existence in the right namespace. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
