https://bugzilla.wikimedia.org/show_bug.cgi?id=31431

Daniel Friesen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mediawiki-bugs@nadir-seen-f
                   |                            |ire.com

--- Comment #1 from Daniel Friesen <[email protected]> 
2011-10-06 16:41:42 UTC ---
The fact that it's a special page error is a separate bug (we need to implement
a real Badtitle special page).

The bug appears to be due to our title handling:

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Wiki.php?view=markup#l62

Instead of calling Title::newFromURL the code that handles the &curid=
activates when you have a &curid= however because the title was deleted and the
page_id no longer exists Title::newFromID returns null and Badtitle is
returned.

I think we should change that set of code to work on the "if it's not set
model". ie: Instead of elseif, each of those blocks is a `if ( is_null( $ret )
&& [...] )` then if any case is active but the Title:: for that case returns
null the next case will activate.

In the case of a &curid=###&title= if &curid= exists it will override but if it
doesn't &title= will return a title.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to