https://bugzilla.wikimedia.org/show_bug.cgi?id=31445

--- Comment #3 from Brion Vibber <[email protected]> 2011-10-07 01:02:45 UTC 
---
I'm a bit suspicious of r92703 -- this forces the editSection setting off on
OutputPage's own mParserOptions on first creation. Might it be getting used
sometimes for some reason?

The 'editsection' user option appears in ParserOutput's legacyOptions() -- but
won't get recorded if it's not used...

Aha! r90214 removes a $this->optionUsed('editsection') which would be necessary
to record the use of the setting on the ParserOptions....

... which was only added in r88988 for bug 29123, and reverted for fragmenting
cache and Platonides being unable to repro the problem.


I think the proper thing to do here is actually to remove all those
$parserOptions->setEditSection(false) in Article::view etc -- rather it should
always turn section edit links *on*, and we should make sure they're *hidden*
for people without edit permissions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to